fix: validate sampling/createMessage with correct schema#1387
Closed
yaonyan wants to merge 3 commits intomodelcontextprotocol:mainfrom
Closed
fix: validate sampling/createMessage with correct schema#1387yaonyan wants to merge 3 commits intomodelcontextprotocol:mainfrom
yaonyan wants to merge 3 commits intomodelcontextprotocol:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 9081c72 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
Author
|
I just checked and saw it's actually been fixed, closing it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Select the correct schema (
CreateMessageResultWithToolsSchemavsCreateMessageResultSchema) based on whethertoolswere provided in the request.Motivation and Context
Standard validation was incorrectly rejecting tool call arrays in sampling results because it was always using the non-tool schema. This allows clients to correctly receive tool use content from models.
How Has This Been Tested?
pnpm test:allto ensure no regressions.Types of changes
Checklist